Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: tracing/tracing/model/memory_allocator_dump.html

Issue 1744563002: [memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Address Primiano's comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/memory_allocator_dump.html
diff --git a/tracing/tracing/model/memory_allocator_dump.html b/tracing/tracing/model/memory_allocator_dump.html
index f4a75e8907861b1a3f5595b3b7745a66919498f5..1bf5050586f3baba9109d644a9abd0523b0bb16d 100644
--- a/tracing/tracing/model/memory_allocator_dump.html
+++ b/tracing/tracing/model/memory_allocator_dump.html
@@ -45,6 +45,12 @@ tr.exportTo('tr.model', function() {
// codebase.
this.weak = false;
+ // A list of information about the memory allocator dump (e.g. about how
+ // its attributes were calculated). Each item should be an object with
+ // a mandatory 'type' property and type-specific extra arguments (see
+ // MemoryAllocatorDumpInfoType).
+ this.infos = [];
+
// For debugging purposes.
this.guid = opt_guid;
};
@@ -147,7 +153,7 @@ tr.exportTo('tr.model', function() {
*
* @enum
*/
- var SizeAttributeInfoType = {
+ var MemoryAllocatorDumpInfoType = {
// The provided size of a MemoryAllocatorDump was less than the aggregated
// size of its children.
//
@@ -168,7 +174,7 @@ tr.exportTo('tr.model', function() {
return {
MemoryAllocatorDump: MemoryAllocatorDump,
MemoryAllocatorDumpLink: MemoryAllocatorDumpLink,
- SizeAttributeInfoType: SizeAttributeInfoType
+ MemoryAllocatorDumpInfoType: MemoryAllocatorDumpInfoType
};
});
</script>

Powered by Google App Engine
This is Rietveld 408576698