Issue 1432973005: Prevent EventLogImporter from matching its own file in vulcanized traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1432973005: Prevent EventLogImporter from matching its own file in vulcanized traces (Closed)

Created:
5 years, 1 month ago by petrcermak

Modified:
5 years, 1 month ago

Reviewers:
nduca

CC:
catapult-reviews_chromium.org, tracing-review_chromium.org

Base URL:
git@github.com:catapult-project/catapult.git@master

Target Ref:
refs/heads/master

Project:
catapult

Visibility:
Public.

More Reviews

Description

Prevent EventLogImporter from matching its own file in vulcanized traces This is done by checking if the events start with '<!DOCTYPE html>' in EventLogImporter.canImport. BUG=catapult:#1755 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/be1d5bfcc12562ff9863a08335f2d40d64279a08

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tracing/tracing/extras/importer/android/event_log_importer.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 1744563002 Patch 20001

Issue 2132683002 Patch 1

Issue 2132683002 Patch 20001

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432973005/1

5 years, 1 month ago (2015-11-10 20:33:07 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-10 20:42:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages