Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

Issue 1744133002: Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp
index 29463de6a741e13ee8fcbc97c5d7ade900f81e5f..c5b5e64c07418011ce687a8d20ba88bd1e4f5d30 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp
@@ -43,13 +43,11 @@ namespace blink {
RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create(ExecutionContext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* successCallback, RTCPeerConnectionErrorCallback* errorCallback)
{
- RTCSessionDescriptionRequestImpl* request = new RTCSessionDescriptionRequestImpl(context, requester, successCallback, errorCallback);
- request->suspendIfNeeded();
- return request;
+ return new RTCSessionDescriptionRequestImpl(context, requester, successCallback, errorCallback);
}
RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(ExecutionContext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* successCallback, RTCPeerConnectionErrorCallback* errorCallback)
- : ActiveDOMObject(context)
+ : ContextLifecycleObserver(context)
, m_successCallback(successCallback)
, m_errorCallback(errorCallback)
, m_requester(requester)
@@ -78,7 +76,7 @@ void RTCSessionDescriptionRequestImpl::requestFailed(const String& error)
clear();
}
-void RTCSessionDescriptionRequestImpl::stop()
+void RTCSessionDescriptionRequestImpl::contextDestroyed()
{
clear();
}
@@ -96,7 +94,7 @@ DEFINE_TRACE(RTCSessionDescriptionRequestImpl)
visitor->trace(m_errorCallback);
visitor->trace(m_requester);
RTCSessionDescriptionRequest::trace(visitor);
- ActiveDOMObject::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698