Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(51)

Issue 174381: Merge Webkit 47001 - 20090810 Vitaly Repeshko <vitalyr@quad.spb.corp.google... (Closed)

Created:
9 years, 7 months ago by laforge
Modified:
7 years, 10 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge Webkit 47001 - 20090810 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>; Reviewed by Dimitri Glazkov. [V8] Fix memory leak in node event listeners. See http://crbug.com/17400. https://bugs.webkit.org/show_bug.cgi?id=28156 * bindings/scripts/CodeGeneratorV8.pm: Custom event handler accessors now apply to all Node descendants. * bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::isObjectListener): Added virtual method to detect listeners that have weak references to JS objects. * bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): * bindings/v8/V8ObjectEventListener.cpp: * bindings/v8/V8ObjectEventListener.h: (WebCore::V8ObjectEventListener::isObjectListener): * bindings/v8/V8Utilities.cpp: (WebCore::removeHiddenDependency): * bindings/v8/custom/V8CustomBinding.h: * bindings/v8/custom/V8ElementCustom.cpp: * bindings/v8/custom/V8NodeCustom.cpp: Moved custom accessors from V8ElementCustom.cpp. (WebCore::toEventType): (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Made static. TBR=dglazkov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2302 lines, -2275 lines) Patch
M WebCore/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +2214 lines, -2203 lines 0 comments Download
M WebCore/bindings/v8/V8AbstractEventListener.h View 1 chunk +2 lines, -0 lines 0 comments Download
M WebCore/bindings/v8/V8DOMWrapper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M WebCore/bindings/v8/V8ObjectEventListener.h View 1 chunk +2 lines, -0 lines 0 comments Download
M WebCore/bindings/v8/V8ObjectEventListener.cpp View 1 chunk +9 lines, -11 lines 0 comments Download
M WebCore/bindings/v8/V8Utilities.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M WebCore/bindings/v8/custom/V8CustomBinding.h View 2 chunks +6 lines, -3 lines 0 comments Download
M WebCore/bindings/v8/custom/V8ElementCustom.cpp View 3 chunks +0 lines, -40 lines 0 comments Download
M WebCore/bindings/v8/custom/V8NodeCustom.cpp View 2 chunks +64 lines, -11 lines 0 comments Download
M WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
9 years, 7 months ago (2009-08-25 01:01:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698