Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: WebCore/bindings/v8/V8ObjectEventListener.cpp

Issue 174381: Merge Webkit 47001 - 20090810 Vitaly Repeshko <vitalyr@quad.spb.corp.google... (Closed) Base URL: svn://chrome-svn/chrome/branches/WebKit/195/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebCore/bindings/v8/V8ObjectEventListener.h ('k') | WebCore/bindings/v8/V8Utilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/bindings/v8/V8ObjectEventListener.cpp
===================================================================
--- WebCore/bindings/v8/V8ObjectEventListener.cpp (revision 24197)
+++ WebCore/bindings/v8/V8ObjectEventListener.cpp (working copy)
@@ -54,24 +54,22 @@
listener->disposeListenerObject();
}
-// Object event listeners (such as XmlHttpRequest and MessagePort) are
-// different from listeners on DOM nodes. An object event listener wrapper
-// only holds a weak reference to the JS function. A strong reference can
-// create a cycle.
+// An object event listener wrapper only holds a weak reference to the
+// JS function. A strong reference can create a cycle.
//
-// The lifetime of these objects is bounded by the life time of its JS
-// wrapper. So we can create a hidden reference from the JS wrapper to
-// to its JS function.
+// The lifetime of these objects is bounded by the life time of the JS
+// wrapper of XHR or Node. So we can create a hidden reference from
+// the JS wrapper to to its JS function.
//
// (map)
-// XHR <---------- JS_wrapper
+// XHR or Node <---------- JS_wrapper
// | (hidden) : ^
-// V V : (may reachable by closure)
+// V V : (may be reachable by closure)
// V8_listener --------> JS_function
// (weak) <-- may create a cycle if it is strong
//
-// The persistent reference is made weak in the constructor
-// of V8ObjectEventListener.
+// The persistent reference is made weak in the constructor of
+// V8ObjectEventListener.
V8ObjectEventListener::V8ObjectEventListener(Frame* frame, v8::Local<v8::Object> listener, bool isInline)
: V8EventListener(frame, listener, isInline)
« no previous file with comments | « WebCore/bindings/v8/V8ObjectEventListener.h ('k') | WebCore/bindings/v8/V8Utilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698