Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Unified Diff: WebCore/bindings/v8/V8Utilities.cpp

Issue 174381: Merge Webkit 47001 - 20090810 Vitaly Repeshko <vitalyr@quad.spb.corp.google... (Closed) Base URL: svn://chrome-svn/chrome/branches/WebKit/195/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebCore/bindings/v8/V8ObjectEventListener.cpp ('k') | WebCore/bindings/v8/custom/V8CustomBinding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/bindings/v8/V8Utilities.cpp
===================================================================
--- WebCore/bindings/v8/V8Utilities.cpp (revision 24197)
+++ WebCore/bindings/v8/V8Utilities.cpp (working copy)
@@ -58,7 +58,8 @@
void removeHiddenDependency(v8::Local<v8::Object> object, v8::Local<v8::Value> value, int cacheIndex)
{
v8::Local<v8::Value> cache = object->GetInternalField(cacheIndex);
- ASSERT(cache->IsArray());
+ if (!cache->IsArray())
+ return;
v8::Local<v8::Array> cacheArray = v8::Local<v8::Array>::Cast(cache);
for (int i = cacheArray->Length() - 1; i >= 0; --i) {
v8::Local<v8::Value> cached = cacheArray->Get(v8::Integer::New(i));
@@ -67,9 +68,6 @@
return;
}
}
-
- // We should only get here if we try to remove an event listener that was never added.
- ASSERT_NOT_REACHED();
}
bool processingUserGesture()
« no previous file with comments | « WebCore/bindings/v8/V8ObjectEventListener.cpp ('k') | WebCore/bindings/v8/custom/V8CustomBinding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698