Add fuzzers for import of WebCrypto DER-encoded keys.

Add fuzzers for import of WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer "boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the codepaths for the the PKCS8 formatted imports.

Committed: https://crrev.com/5a6f502d0e2ab2c368dbf3564061695931e882c7
Cr-Commit-Position: refs/heads/master@{#378193}

[eroman, 2016-02-26 23:48:32]

Description was changed from

==========
inprogress
BUG=
==========

to

==========
Add a fuzzer for importing EC keys through WebCrypto using PKCS8
==========

[eroman, 2016-02-27 02:34:30]

Description was changed from

==========
Add a fuzzer for importing EC keys through WebCrypto using PKCS8
==========

to

==========
Add fuzzers for import WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.
==========

[eroman, 2016-02-27 02:36:02]

eroman@chromium.org changed reviewers:
+ mmoroz@chromium.org

[eroman, 2016-02-27 02:36:20]

Description was changed from

==========
Add fuzzers for import WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.
==========

to

==========
Add fuzzers for import of WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.
==========

[mmoroz, 2016-02-29 10:28:58]

LGTM

[mmoroz, 2016-02-29 10:29:04]

The CQ bit was checked by mmoroz@chromium.org

[commit-bot: I haz the power, 2016-02-29 10:29:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763003/40001

[commit-bot: I haz the power, 2016-02-29 11:04:10]

Description was changed from

==========
Add fuzzers for import of WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.
==========

to

==========
Add fuzzers for import of WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.
==========

[commit-bot: I haz the power, 2016-02-29 11:04:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-29 11:05:36]

Description was changed from

==========
Add fuzzers for import of WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.
==========

to

==========
Add fuzzers for import of WebCrypto DER-encoded keys.

 * RSA PKCS8-formatted
 * RSA SPKI-formatted
 * EC PKCS8-formatted
 * EC SPK-formatted

There is potentially some overlap with the existing fuzzer
"boringssl_d2i_autoprivatekey_fuzzer", which should exercise most of the
codepaths for the the PKCS8 formatted imports.

Committed: https://crrev.com/5a6f502d0e2ab2c368dbf3564061695931e882c7
Cr-Commit-Position: refs/heads/master@{#378193}
==========

[commit-bot: I haz the power, 2016-02-29 11:05:37]

Patchset 3 (id:??) landed as
https://crrev.com/5a6f502d0e2ab2c368dbf3564061695931e882c7
Cr-Commit-Position: refs/heads/master@{#378193}

[Nico, 2017-03-26 03:14:38]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-03-26 03:14:39]

https://codereview.chromium.org/1743763003/diff/40001/components/webcrypto/BU...
File components/webcrypto/BUILD.gn (right):

https://codereview.chromium.org/1743763003/diff/40001/components/webcrypto/BU...
components/webcrypto/BUILD.gn:162: "rsa_import_key_pkcs8_fuzzer.cc",
You copied rsa_import_key_pkcs8_fuzzer here and forgot to change the sources
line. None of your fuzzers uses rsa_import_key_spki_fuzzer.cc but two use
rsa_import_key_pkcs8_fuzzer.cc. Whoops! :-)

[eroman, 2017-03-30 17:02:59]

https://codereview.chromium.org/1743763003/diff/40001/components/webcrypto/BU...
File components/webcrypto/BUILD.gn (right):

https://codereview.chromium.org/1743763003/diff/40001/components/webcrypto/BU...
components/webcrypto/BUILD.gn:162: "rsa_import_key_pkcs8_fuzzer.cc",
On 2017/03/26 03:14:39, Nico (afk until Tue Apr 4) wrote:
> You copied rsa_import_key_pkcs8_fuzzer here and forgot to change the sources
> line. None of your fuzzers uses rsa_import_key_spki_fuzzer.cc but two use
> rsa_import_key_pkcs8_fuzzer.cc. Whoops! :-)

Ugh, I am terrible :(

Thanks for pointing this out!