Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1741893003: Introduce v8::MicrotasksScope. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce v8::MicrotasksScope. This scope is used to control microtasks execution when MicrotasksPolicy::kScoped is engaged. Attempt #2. First one was reverted due to chromium breakage: SetAutorunMicrotasks(false) was broken. BUG=chromium:585949 LOG=Y TEST=ScopedMicrotasks Committed: https://crrev.com/9a1387f6a965edb295931012b4f76c689c02a5c2 Cr-Commit-Position: refs/heads/master@{#34504}

Patch Set 1 : Separate scopes #

Patch Set 2 : Merged scopes #

Total comments: 10

Patch Set 3 : tests, simplified #

Patch Set 4 : nit #

Patch Set 5 : bool -> int typo, allow scopes to have no effect when different policy is in place #

Patch Set 6 : relaxed DCHECK, fixed new test #

Patch Set 7 : SetAutorunMicrotasks fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -19 lines) Patch
M include/v8.h View 1 2 3 4 2 chunks +57 lines, -7 lines 0 comments Download
M src/api.h View 1 2 3 4 4 chunks +49 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 6 6 chunks +77 lines, -2 lines 0 comments Download
M src/isolate.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 7 chunks +150 lines, -6 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (15 generated)
dgozman
Could you please take a look? Here I follow the plan outlined in crbug.com/585949, basically ...
4 years, 10 months ago (2016-02-27 03:05:42 UTC) #3
jochen (gone - plz use gerrit)
deferring to adamk for the meat of the CL https://codereview.chromium.org/1741893003/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1741893003/diff/20001/include/v8.h#newcode5461 include/v8.h:5461: ...
4 years, 9 months ago (2016-03-01 14:26:08 UTC) #5
adamk
Found the new code in api.cc pretty hard to read without understanding all the new ...
4 years, 9 months ago (2016-03-01 19:10:34 UTC) #6
dgozman
PTAL I've added more comments and simplified by not merging scope classes. This makes it ...
4 years, 9 months ago (2016-03-03 01:22:06 UTC) #8
adamk
Thanks for the the comments and simplifications, this now lgtm. You might want to wait ...
4 years, 9 months ago (2016-03-03 01:57:20 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-03 05:13:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741893003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741893003/80001
4 years, 9 months ago (2016-03-03 20:14:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/3732) v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-03 20:30:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741893003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741893003/100001
4 years, 9 months ago (2016-03-04 00:56:36 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-04 04:01:17 UTC) #19
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/db77cec242dbdf8ee26da8232fa930270429f253 Cr-Commit-Position: refs/heads/master@{#34472}
4 years, 9 months ago (2016-03-04 04:02:44 UTC) #21
Michael Achenbach
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1762943002/ by machenbach@chromium.org. ...
4 years, 9 months ago (2016-03-04 07:30:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741893003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741893003/120001
4 years, 9 months ago (2016-03-04 17:09:47 UTC) #26
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-04 17:41:44 UTC) #28
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 17:42:26 UTC) #30
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9a1387f6a965edb295931012b4f76c689c02a5c2
Cr-Commit-Position: refs/heads/master@{#34504}

Powered by Google App Engine
This is Rietveld 408576698