test/cctest/test-thread-termination.cc - Issue 1741893003: Introduce v8::MicrotasksScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-thread-termination.cc

Issue 1741893003: Introduce v8::MicrotasksScope. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: SetAutorunMicrotasks fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-thread-termination.cc

diff --git a/test/cctest/test-thread-termination.cc b/test/cctest/test-thread-termination.cc

index 05a3c3339e48d9acf25b7b60c6006fc9f00e3bbd..85dfd13b602fa9abb0294f0772cdbc98bed1a6c3 100644

--- a/test/cctest/test-thread-termination.cc

+++ b/test/cctest/test-thread-termination.cc

@@ -403,7 +403,7 @@ TEST(TerminateFromOtherThreadWhileMicrotaskRunning) {

thread.Start();

v8::Isolate* isolate = CcTest::isolate();

- isolate->SetAutorunMicrotasks(false);

+ isolate->SetMicrotasksPolicy(v8::MicrotasksPolicy::kExplicit);

v8::HandleScope scope(isolate);

v8::Local<v8::ObjectTemplate> global =

CreateGlobalTemplate(CcTest::isolate(), Signal, DoLoop);

« no previous file with comments | « test/cctest/test-microtask-delivery.cc ('k') | no next file » | no next file with comments »