Add hooks for GL_EXT_debug_marker in gpu

Add hooks for GL_EXT_debug_marker in gpu

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13538

[bsalomon, 2014-02-20 22:14:13]

https://codereview.chromium.org/174123003/diff/1/include/gpu/gl/GrGLInterface.h
File include/gpu/gl/GrGLInterface.h (right):

https://codereview.chromium.org/174123003/diff/1/include/gpu/gl/GrGLInterface...
include/gpu/gl/GrGLInterface.h:81: const GrGLInterface*
GrGLInterfaceAddTestDebugMarker(const GrGLInterface*);
I think this might prove generally useful... perhaps it should just take the
three function ptrs to install (push, insert, pop)

https://codereview.chromium.org/174123003/diff/1/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/174123003/diff/1/src/gpu/GrDrawTarget.h#newco...
src/gpu/GrDrawTarget.h:430: virtual void insertEventMarker(const char* marker)
{};
= 0?

Or make the GrDT track the push count and assert it's always >= 0. (and call
onFoo virtuals).

https://codereview.chromium.org/174123003/diff/1/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/174123003/diff/1/src/gpu/GrGpu.h#newcode466
src/gpu/GrGpu.h:466: // overridden by backend-specific derived class to perform
debug markers
I'd bubble the foo/onFoo split up to GrDT. We can have asserts, filters, etc
that get applied for all GrDT subclasses. And at that level we don't need a
double virtual call, the public ones can be non-virtual.

https://codereview.chromium.org/174123003/diff/1/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/174123003/diff/1/src/gpu/gl/GrGLCaps.cpp#newc...
src/gpu/gl/GrGLCaps.cpp:304: 
?

https://codereview.chromium.org/174123003/diff/1/src/gpu/gl/GrGLInterface.cpp
File src/gpu/gl/GrGLInterface.cpp (right):

https://codereview.chromium.org/174123003/diff/1/src/gpu/gl/GrGLInterface.cpp...
src/gpu/gl/GrGLInterface.cpp:29: newInterface->fInsertEventMarker =
testInsertEventMarker;
Where are these defined?

https://codereview.chromium.org/174123003/diff/1/src/gpu/gl/iOS/GrGLCreateNat...
File src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp (right):

https://codereview.chromium.org/174123003/diff/1/src/gpu/gl/iOS/GrGLCreateNat...
src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp:148:
functions->fInsertEventMarker = glInsertEventMarkerEXT;
I think we either have to dynamically load the function addrs or guard this with
#if GL_EXT_... or else these symbols won't be found.

[bsalomon, 2014-02-21 15:33:01]

two minor comments inline

https://codereview.chromium.org/174123003/diff/320001/include/gpu/gl/GrGLInte...
File include/gpu/gl/GrGLInterface.h (right):

https://codereview.chromium.org/174123003/diff/320001/include/gpu/gl/GrGLInte...
include/gpu/gl/GrGLInterface.h:83: GrGLPushGroupMarkerProc fPushGM,
fIsForFieldsAKAMembersOfStructsOrClasses

https://codereview.chromium.org/174123003/diff/320001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/174123003/diff/320001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:566: SkASSERT(1 <= fDebugPushCount);
We only require yodaspeak when using == (to void accidentally assigning).

[egdaniel, 2014-02-21 16:59:10]

Changed names of function for placing markers to be more general and not
directly tied to the GL_EXT_debug_marker

[bsalomon, 2014-02-21 17:03:07]

lgtm with two minor comments.

https://codereview.chromium.org/174123003/diff/650001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/174123003/diff/650001/src/gpu/GrGpu.h#newcode462
src/gpu/GrGpu.h:462: virtual void onInstantGpuTraceEvent(const char* marker)
SK_OVERRIDE = 0;
I don't think we need to redeclare these as pure virtual here.

https://codereview.chromium.org/174123003/diff/650001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/174123003/diff/650001/src/gpu/gl/GrGpuGL.cpp#...
src/gpu/gl/GrGpuGL.cpp:2669: void GrGpuGL::onPushGpuTraceEvent(const char*
marker){
spaces between function defns.

[egdaniel, 2014-02-21 17:40:58]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-02-21 17:41:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/egdaniel@google.com/174123003/780001

[commit-bot: I haz the power, 2014-02-21 18:24:03]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/egdaniel@google.com/174123003/780001

[commit-bot: I haz the power, 2014-02-21 18:24:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 18:24:12]

Failed to apply patch for include/gpu/gl/GrGLExtensions.h:
While running git apply --index -p1;
  Created missing directory include/gpu/gl.
  error: include/gpu/gl/GrGLExtensions.h: does not exist in index

Patch:       include/gpu/gl/GrGLExtensions.h
Index: include/gpu/gl/GrGLExtensions.h
diff --git a/include/gpu/gl/GrGLExtensions.h b/include/gpu/gl/GrGLExtensions.h
index
76516cf11f9fff31a7b1044c46aeb65e9fc9d1bb..dbfc3be45e7fdb1a94f3802622d8cbf348a972b7
100644
--- a/include/gpu/gl/GrGLExtensions.h
+++ b/include/gpu/gl/GrGLExtensions.h
@@ -54,6 +54,11 @@ public:
      */
     bool remove(const char[]);
 
+    /**
+     * Adds an extension to list
+     */
+    void add(const char[]);
+
     void reset() { fStrings->reset(); }
 
     void print(const char* sep = "\n") const;

[egdaniel, 2014-02-21 18:30:31]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-02-21 18:30:43]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/egdaniel@google.com/174123003/780001

[commit-bot: I haz the power, 2014-02-21 18:45:45]

Change committed as 13538