Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1740883002: Increase location bar bubble font padding in material hybrid (Closed)

Created:
4 years, 10 months ago by tdanderson
Modified:
4 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase location bar bubble font padding in material hybrid For the material design hybrid variant in top chrome, increase the padding between the edge of a location bar bubble and its contained text from 2 to 4. BUG=584680 TEST=manual Committed: https://crrev.com/bc81f90a9a31d1e6f899a28c3928194ce718f7b6 Cr-Commit-Position: refs/heads/master@{#377807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/ui/layout_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/layout_constants.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tdanderson
Peter, can you please take a look?
4 years, 10 months ago (2016-02-25 22:12:11 UTC) #2
Peter Kasting
LGTM
4 years, 10 months ago (2016-02-25 23:56:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740883002/1
4 years, 10 months ago (2016-02-26 02:51:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 04:12:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 04:13:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc81f90a9a31d1e6f899a28c3928194ce718f7b6
Cr-Commit-Position: refs/heads/master@{#377807}

Powered by Google App Engine
This is Rietveld 408576698