Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4286)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 1740883002: Increase location bar bubble font padding in material hybrid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/layout_constants.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 4776f979ff0ce24219d29db4e9ab59ea50a0ec3b..c4426aaa00a3fb796bb38b6dff712a37a43a435f 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -194,7 +194,7 @@ void LocationBarView::Init() {
const gfx::Insets omnibox_border_insets(14, 9, 14, 9);
border_painter_.reset(views::Painter::CreateImagePainter(
*rb.GetImageSkiaNamed(IDR_OMNIBOX_BORDER), omnibox_border_insets));
-}
+ }
// Determine the main font.
gfx::FontList font_list = ResourceBundle::GetSharedInstance().GetFontList(
@@ -213,11 +213,9 @@ void LocationBarView::Init() {
font_list = font_list.DeriveWithHeightUpperBound(location_height);
// Determine the font for use inside the bubbles.
- const int kBubbleFontVerticalPadding =
- ui::MaterialDesignController::IsModeMaterial() ? 2 : 1;
const int bubble_padding =
GetLayoutConstant(LOCATION_BAR_BUBBLE_VERTICAL_PADDING) +
- kBubbleFontVerticalPadding;
+ GetLayoutConstant(LOCATION_BAR_BUBBLE_FONT_VERTICAL_PADDING);
const int bubble_height = location_height - (bubble_padding * 2);
gfx::FontList bubble_font_list =
font_list.DeriveWithHeightUpperBound(bubble_height);
« no previous file with comments | « chrome/browser/ui/layout_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698