Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1739763002: Create Response namespace for skiaserve response functions (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@skiaserve-3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -96 lines) Patch
A tools/skiaserve/Response.h View 1 chunk +30 lines, -0 lines 0 comments Download
A tools/skiaserve/Response.cpp View 1 1 chunk +114 lines, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 3 chunks +3 lines, -96 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-25 16:14:15 UTC) #3
ethannicholas
lgtm
4 years, 10 months ago (2016-02-25 18:16:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739763002/20001
4 years, 10 months ago (2016-02-25 18:52:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 19:09:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/26cc3f5ad0aacf80bba162bab4b23a2901ffed17

Powered by Google App Engine
This is Rietveld 408576698