Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1733813004: Move some methods to SkiaServe's Request, this is still very leaky (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@skiaserve-2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : kbudgeted stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -116 lines) Patch
M tools/skiaserve/Request.h View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/skiaserve/Request.cpp View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 2 13 chunks +14 lines, -116 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-25 15:55:34 UTC) #3
ethannicholas
lgtm
4 years, 10 months ago (2016-02-25 18:18:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733813004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733813004/20001
4 years, 10 months ago (2016-02-25 18:19:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/632) Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 10 months ago (2016-02-25 18:20:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733813004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733813004/60001
4 years, 10 months ago (2016-02-25 18:28:23 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 18:50:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4dcbe431244c2f1abef8416b95ebf2921708fa63

Powered by Google App Engine
This is Rietveld 408576698