Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1737643003: Move urlhandlers out of skiaserve.cpp (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@skiaserve-4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+666 lines, -449 lines) Patch
M gyp/skiaserve.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 2 chunks +3 lines, -449 lines 0 comments Download
A tools/skiaserve/urlhandlers/BreakHandler.cpp View 1 chunk +99 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/ClipAlphaHandler.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/CmdHandler.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/DataHandler.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/DownloadHandler.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/EnableGPUHandler.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/ImgHandler.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/InfoHandler.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/PostHandler.cpp View 1 chunk +84 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/RootHandler.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/UrlHandler.h View 1 chunk +111 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
joshualitt
this is just a code move, ptal
4 years, 9 months ago (2016-02-25 17:22:01 UTC) #3
ethannicholas
lgtm
4 years, 9 months ago (2016-02-25 18:14:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737643003/20001
4 years, 9 months ago (2016-02-25 19:16:00 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 19:28:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3854f11ce35857ccb6dbf8bb09bef9252543090f

Powered by Google App Engine
This is Rietveld 408576698