Blink Compositor Animation: Erase old animation system.

Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is always true.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/510a9b6ff13b7d569c98c847b2e83155501a4769
Cr-Commit-Position: refs/heads/master@{#378629}

[loyso (OOO), 2016-02-26 05:28:54]

Description was changed from

==========
Blink Compositor Animation: Erase old animation system.

BUG=575041
==========

to

==========
Blink Compositor Animation: Erase old animation system.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-26 05:30:33]

Description was changed from

==========
Blink Compositor Animation: Erase old animation system.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor Animation: Erase old animation system.

DO NOT LAND FOR NOW.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-26 05:32:03]

loyso@chromium.org changed reviewers:
+ aelias@chromium.org, ajuma@chromium.org, chrishtr@chromium.org,
dstockwell@chromium.org, esprehn@chromium.org, vollick@chromium.org

[loyso (OOO), 2016-02-26 05:34:05]

loyso@chromium.org changed reviewers:
+ cpu@chromium.org, sievers@chromium.org, sky@chromium.org

[loyso (OOO), 2016-02-26 05:34:53]

loyso@chromium.org changed reviewers:
+ mpearson@google.com

[cpu_(ooo_6.6-7.5), 2016-02-26 20:18:08]

cpu@chromium.org changed reviewers:
- cpu@chromium.org

[loyso (OOO), 2016-02-29 00:09:00]

loyso@chromium.org changed reviewers:
+ dalecurtis@chromium.org, tkent@chromium.org

[loyso (OOO), 2016-02-29 01:58:35]

Description was changed from

==========
Blink Compositor Animation: Erase old animation system.

DO NOT LAND FOR NOW.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-29 02:38:53]

Description was changed from

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-29 04:25:56]

Owners, PTAL at your primary system! This is a trivial deletion. Thanks in
advance!

[tkent, 2016-02-29 04:30:47]

third_party/WebKit lgtm

[loyso (OOO), 2016-02-29 06:25:00]

https://codereview.chromium.org/1739743003/diff/40001/cc/layers/video_layer.h
File cc/layers/video_layer.h (right):

https://codereview.chromium.org/1739743003/diff/40001/cc/layers/video_layer.h...
cc/layers/video_layer.h:12: #include "cc/layers/layer_settings.h"
This is temp to comply with current DEPS. It willl be erased in next CL along
with layer_settings.h/cc

[Ian Vollick, 2016-02-29 13:21:38]

This is exciting! lgtm with a few small questions.

What's the plan for getting rid of --ui-disable-blah-blah?

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left):

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:38:
CompositorAnimationTimelines
This is taking the REF from "not enabled anywhere by default" to always enabled,
correct?

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp (left):

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp:128: if
(RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled()) {
Can you please remind me how this got enabled during the unit test?

[Ian Vollick, 2016-02-29 13:23:08]

On 2016/02/29 13:21:38, vollick wrote:
> This is exciting! lgtm with a few small questions.
> 
> What's the plan for getting rid of --ui-disable-blah-blah?

..and answered my own question by looking at the next cl in my queue:
https://codereview.chromium.org/1749573002/.

(blush)
> 
>
https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left):
> 
>
https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:38:
> CompositorAnimationTimelines
> This is taking the REF from "not enabled anywhere by default" to always
enabled,
> correct?
> 
>
https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp (left):
> 
>
https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp:128: if
> (RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled()) {
> Can you please remind me how this got enabled during the unit test?

[Mark P, 2016-02-29 18:09:19]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2016-02-29 18:09:20]

https://codereview.chromium.org/1739743003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1739743003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:71526: -  <int value="-1892555086"
label="disable-compositor-animation-timelines"/>
Please do not delete entries.  They help provide labels to entries on the
dashboard.

[loyso (OOO), 2016-02-29 22:39:28]

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left):

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:38:
CompositorAnimationTimelines
On 2016/02/29 13:21:37, vollick wrote:
> This is taking the REF from "not enabled anywhere by default" to always
enabled,
> correct?
It was always enabled by default. Now we just erase it.

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp (left):

https://codereview.chromium.org/1739743003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp:128: if
(RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled()) {
On 2016/02/29 13:21:37, vollick wrote:
> Can you please remind me how this got enabled during the unit test?

See content/test/test_blink_web_unit_test_support.cc change in this CL.

https://codereview.chromium.org/1739743003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1739743003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:71526: -  <int value="-1892555086"
label="disable-compositor-animation-timelines"/>
On 2016/02/29 18:09:20, Mark P wrote:
> Please do not delete entries.  They help provide labels to entries on the
> dashboard.

Acknowledged.

[loyso (OOO), 2016-02-29 22:41:04]

Content/, media/, chrome/ review needed! PTAL!

[esprehn, 2016-03-01 01:21:15]

This patch is so big it's a bit hard to review, but I think it seems legit.

lgtm

[DaleCurtis, 2016-03-01 23:21:58]

lgtm

[loyso (OOO), 2016-03-01 23:28:11]

loyso@chromium.org changed reviewers:
- aelias@chromium.org, ajuma@chromium.org, chrishtr@chromium.org,
dstockwell@chromium.org, mpearson@chromium.org, mpearson@google.com,
sievers@chromium.org, sky@chromium.org

[Avi (use Gerrit), 2016-03-01 23:51:09]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-03-01 23:51:10]

lgtm

deletion!

[sky, 2016-03-02 00:27:02]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-02 00:27:03]

LGTM

[loyso (OOO), 2016-03-02 00:33:27]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-03-02 00:33:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/1739743003/#ps60001
(title: "Exclude histograms.xml")

[commit-bot: I haz the power, 2016-03-02 00:34:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739743003/60001

[commit-bot: I haz the power, 2016-03-02 00:43:06]

Description was changed from

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-02 00:43:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-02 00:44:31]

Description was changed from

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor Animation: Erase old animation system.

Basically, specialize all the code as if use_compositor_animation_timelines is
always true.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/510a9b6ff13b7d569c98c847b2e83155501a4769
Cr-Commit-Position: refs/heads/master@{#378629}
==========

[commit-bot: I haz the power, 2016-03-02 00:44:33]

Patchset 4 (id:??) landed as
https://crrev.com/510a9b6ff13b7d569c98c847b2e83155501a4769
Cr-Commit-Position: refs/heads/master@{#378629}