Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1749573002: CC Animation: Erase old animation system in UI Compositor. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
CC:
achuith+watch_chromium.org, asvitkine+watch_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, esprehn, jam, jbauman+watch_chromium.org, kalyank, oshima+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@eraseblink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase old animation system in UI Compositor. Basically, specialize all the code as if use_compositor_animation_timelines is always true. Next CL: Erase cc::LayerSettings everywhere. BUG=575041 Committed: https://crrev.com/5311049ef3f3948c515f317057a259518e41410e Cr-Commit-Position: refs/heads/master@{#378886}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Exclude histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -144 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/compositor/layer.h View 1 7 chunks +1 line, -19 lines 0 comments Download
M ui/compositor/layer.cc View 1 11 chunks +11 lines, -82 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/compositor/layer_owner_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/compositor/test/test_suite.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (13 generated)
loyso (OOO)
4 years, 9 months ago (2016-02-29 06:13:43 UTC) #5
Ian Vollick
On 2016/02/29 06:13:43, loyso wrote: lgtm!
4 years, 9 months ago (2016-02-29 13:26:34 UTC) #6
Mark P
https://codereview.chromium.org/1749573002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1749573002/diff/1/tools/metrics/histograms/histograms.xml#oldcode71805 tools/metrics/histograms/histograms.xml:71805: - <int value="323605372" label="ui-disable-compositor-animation-timelines"/> Please do not delete entries. ...
4 years, 9 months ago (2016-02-29 18:09:13 UTC) #7
loyso (OOO)
content/ and chrome/ review needed! PTAL. This is a trivial deletion.
4 years, 9 months ago (2016-02-29 22:43:14 UTC) #8
loyso (OOO)
jochen@chromium.org: Please review changes in gpu_transport_factory.cc, please!
4 years, 9 months ago (2016-02-29 22:49:20 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 14:40:48 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 1739743003 Patch 60001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-01 14:53:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749573002/20001
4 years, 9 months ago (2016-03-02 23:04:58 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-03 00:12:02 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 00:14:02 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5311049ef3f3948c515f317057a259518e41410e
Cr-Commit-Position: refs/heads/master@{#378886}

Powered by Google App Engine
This is Rietveld 408576698