Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1739193003: Timeline: extract and rename TracingModelLoader into a file of its own (Closed)

Created:
4 years, 10 months ago by caseq
Modified:
4 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: extract and rename TracingModelLoader into a file of its own This just extracts TimelineLoader with the aim of later refactoring it to untangle timeline lifecycle events from TimelineModel. Committed: https://crrev.com/b994e8b0a8af48aca6aa2182b5e8157b4873c0e9 Cr-Commit-Position: refs/heads/master@{#378109}

Patch Set 1 #

Patch Set 2 : +delegate #

Patch Set 3 : also moved loadTimelineFrom to TimelineLoader #

Total comments: 4

Patch Set 4 : review comments addressed #

Messages

Total messages: 15 (8 generated)
caseq
4 years, 10 months ago (2016-02-26 23:33:03 UTC) #2
alph
lgtm https://codereview.chromium.org/1739193003/diff/40001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js (right): https://codereview.chromium.org/1739193003/diff/40001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js#newcode54 third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js:54: WebInspector.TimelineLoader._createFileReader = function(file, delegate) annotate plz https://codereview.chromium.org/1739193003/diff/40001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js#newcode63 third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js:63: ...
4 years, 10 months ago (2016-02-27 00:29:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739193003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739193003/60001
4 years, 10 months ago (2016-02-27 00:44:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739193003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739193003/60001
4 years, 10 months ago (2016-02-27 00:53:10 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-27 03:58:09 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/b994e8b0a8af48aca6aa2182b5e8157b4873c0e9 Cr-Commit-Position: refs/heads/master@{#378109}
4 years, 10 months ago (2016-02-27 03:59:12 UTC) #14
nektarios
4 years, 9 months ago (2016-02-29 20:43:31 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1752453002/ by nektar@chromium.org.

The reason for reverting is: Possible cause behind failure in webkit-tests on
WebKit Mac10.11 and WebKit Mac10.11 (retina)..

Powered by Google App Engine
This is Rietveld 408576698