third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js - Issue 1739193003: Timeline: extract and rename TracingModelLoader into a file of its own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1739193003: Timeline: extract and rename TracingModelLoader into a file of its own (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

index 8a67949084aad23c39ceac0d50071a0b65d52c79..dab326240c4b5760d3696fbc384d35a17fc5f0ff 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -536,7 +536,7 @@ WebInspector.TimelinePanel.prototype = {

{

if (this._state !== WebInspector.TimelinePanel.State.Idle)

return;

- this._model.loadFromFile(file, this._prepareToLoadTimeline());

+ WebInspector.TimelineLoader.loadFromFile(this._model, file, this._prepareToLoadTimeline());

this._createFileSelector();

@@ -547,7 +547,7 @@ WebInspector.TimelinePanel.prototype = {

{

if (this._state !== WebInspector.TimelinePanel.State.Idle)

return;

- this._model.loadFromURL(url, this._prepareToLoadTimeline());

+ WebInspector.TimelineLoader.loadFromURL(this._model, url, this._prepareToLoadTimeline());

_refreshViews: function()