third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html - Issue 1739193003: Timeline: extract and rename TracingModelLoader into a file of its own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html

Issue 1739193003: Timeline: extract and rename TracingModelLoader into a file of its own (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-window-filter.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html

index 586bf487fec071c70a7a464a7ac499eff2b95d48..88ee61d088960f0402e15f5ebeaa2f20b84ccae1 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html

@@ -8,8 +8,6 @@

function test()

{

- var timelineData = InspectorTest.timelineData();

var timeline = WebInspector.panels.timeline;

timeline._onModeChanged();

timeline._currentViews[0]._automaticallySizeWindow = true;

@@ -21,16 +19,8 @@ function test()

}

timeline.requestWindowTimes = requestWindowTimesHook;

- var model = timeline._model;

- function createFileReader(file, delegate)

- {

- return new InspectorTest.FakeFileReader(timelineData, delegate, timeline._saveToFile.bind(timeline));

- }

- InspectorTest.override(model, "_createFileReader", createFileReader);

+ InspectorTest.loadTimeline(InspectorTest.timelineData());

- model.loadFromFile({}, new WebInspector.Progress());

InspectorTest.completeTest();

}