extensions/browser/runtime_data_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/runtime_data_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « extensions/browser/mojo/keep_alive_impl_unittest.cc ('k') | extensions/browser/updater/update_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/runtime_data_unittest.cc

diff --git a/extensions/browser/runtime_data_unittest.cc b/extensions/browser/runtime_data_unittest.cc

index 6e522a4db78ddc992226fa102968399f15401995..790dd257bc018fc07971fc602be5e7edb5b6afaa 100644

--- a/extensions/browser/runtime_data_unittest.cc

+++ b/extensions/browser/runtime_data_unittest.cc

@@ -21,12 +21,12 @@ namespace {

// Creates a very simple extension with a background page.

scoped_refptr<Extension> CreateExtensionWithBackgroundPage() {

return ExtensionBuilder()

- .SetManifest(std::move(

- DictionaryBuilder()

- .Set("name", "test")

- .Set("version", "0.1")

- .Set("background",

- std::move(DictionaryBuilder().Set("page", "bg.html")))))

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "test")

+ .Set("version", "0.1")

+ .Set("background",

+ DictionaryBuilder().Set("page", "bg.html").Build())

+ .Build())

.SetID("id2")

.Build();

}