chrome/browser/ui/webui/print_preview/extension_printer_handler.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/extension_printer_handler.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/ui/webui/policy_ui_browsertest.cc ('k') | chrome/browser/ui/webui/uber/uber_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/extension_printer_handler.cc

diff --git a/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc b/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc

index 11b571ec16703c50a5470a4079233a3b0f8ce268..af963e016d207ce1480b4103d7716d0534b83f58 100644

--- a/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc

+++ b/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc

@@ -352,7 +352,7 @@ void ExtensionPrinterHandler::OnUsbDevicesEnumerated(

continue;

}

- printer_list.Append(std::move(

+ printer_list.Append(

DictionaryBuilder()

.Set("id", GenerateProvisionalUsbPrinterId(extension.get(),

device.get()))

@@ -363,7 +363,8 @@ void ExtensionPrinterHandler::OnUsbDevicesEnumerated(

device->product_string(), base::string16(), false))

.Set("extensionId", extension->id())

.Set("extensionName", extension->name())

- .Set("provisional", true)));

+ .Set("provisional", true)

+ .Build());

}