chrome/browser/ui/webui/policy_ui_browsertest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/policy_ui_browsertest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc ('k') | chrome/browser/ui/webui/print_preview/extension_printer_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/policy_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/policy_ui_browsertest.cc b/chrome/browser/ui/webui/policy_ui_browsertest.cc

index 2a4af9da767632d0ab6ea166cd8df0d627f9a269..effcdc6555827862b656aec7ab5e99a620e7179f 100644

--- a/chrome/browser/ui/webui/policy_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/policy_ui_browsertest.cc

@@ -312,11 +312,11 @@ IN_PROC_BROWSER_TEST_F(PolicyUITest, ExtensionLoadAndSendPolicy) {

manifest.Set("name", "test")

.Set("version", "1")

.Set("manifest_version", 2)

- .Set("storage", std::move(storage));

+ .Set("storage", storage.Build());

extensions::ExtensionBuilder builder;

builder.SetPath(temp_dir_.path());

- builder.SetManifest(std::move(manifest));

+ builder.SetManifest(manifest.Build());

// Install extension.

ExtensionService* service = extensions::ExtensionSystem::Get(