Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5319)

Unified Diff: chrome/browser/site_details_browsertest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/site_details_browsertest.cc
diff --git a/chrome/browser/site_details_browsertest.cc b/chrome/browser/site_details_browsertest.cc
index d24f0f16f608ba9030a995a31b0816ee027a8568..e09c5131d4f138e44184abe593f6df0f8085f083 100644
--- a/chrome/browser/site_details_browsertest.cc
+++ b/chrome/browser/site_details_browsertest.cc
@@ -191,17 +191,18 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
manifest.Set("name", name)
.Set("version", "1.0")
.Set("manifest_version", 2)
- .Set("web_accessible_resources",
- std::move(ListBuilder()
- .Append("blank_iframe.html")
- .Append("http_iframe.html")
- .Append("two_http_iframes.html")));
+ .Set("web_accessible_resources", ListBuilder()
+ .Append("blank_iframe.html")
+ .Append("http_iframe.html")
+ .Append("two_http_iframes.html")
+ .Build());
if (has_background_process) {
manifest.Set(
"background",
- std::move(DictionaryBuilder().Set(
- "scripts", std::move(ListBuilder().Append("script.js")))));
+ DictionaryBuilder()
+ .Set("scripts", ListBuilder().Append("script.js").Build())
+ .Build());
dir->WriteFile(FILE_PATH_LITERAL("script.js"),
"console.log('" + name + " running');");
}
@@ -248,12 +249,13 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
manifest.Set("name", name)
.Set("version", "1.0")
.Set("manifest_version", 2)
- .Set("app",
- std::move(DictionaryBuilder()
- .Set("urls",
- std::move(ListBuilder().Append(app_url.spec())))
- .Set("launch", std::move(DictionaryBuilder().Set(
- "web_url", app_url.spec())))));
+ .Set(
+ "app",
+ DictionaryBuilder()
+ .Set("urls", ListBuilder().Append(app_url.spec()).Build())
+ .Set("launch",
+ DictionaryBuilder().Set("web_url", app_url.spec()).Build())
+ .Build());
dir->WriteManifest(manifest.ToJSON());
const Extension* extension = LoadExtension(dir->unpacked_path());

Powered by Google App Engine
This is Rietveld 408576698