Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8011)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
index 2320c93f4e5d04dd2c0dd610597e05fc18e53016..97b7fb9124e609e4f02409a4fe0338f28df8fb13 100644
--- a/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
@@ -84,12 +84,13 @@ void ExtensionTestingProfile::AddExtension(std::string extension_id,
scoped_refptr<extensions::Extension> extension =
extensions::ExtensionBuilder()
.SetID(extension_id)
- .SetManifest(std::move(extensions::DictionaryBuilder()
- .Set("name", extension_name)
- .Set("version", version)
- .Set("manifest_version", 2)
- .Set("description", description)
- .Set("update_url", update_url)))
+ .SetManifest(extensions::DictionaryBuilder()
+ .Set("name", extension_name)
+ .Set("version", version)
+ .Set("manifest_version", 2)
+ .Set("description", description)
+ .Set("update_url", update_url)
+ .Build())
.Build();
// Install the extension on the faked extension service.

Powered by Google App Engine
This is Rietveld 408576698