chrome/browser/metrics/extensions_metrics_provider_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/extensions_metrics_provider_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/webstore_startup_installer_browsertest.cc ('k') | chrome/browser/notifications/message_center_settings_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/extensions_metrics_provider_unittest.cc

diff --git a/chrome/browser/metrics/extensions_metrics_provider_unittest.cc b/chrome/browser/metrics/extensions_metrics_provider_unittest.cc

index 34bab3553aefcc9555f0740ccc8ba41ce42a7ddc..bd6b4472d18b0318b8cf0c76043b9977dc00e544 100644

--- a/chrome/browser/metrics/extensions_metrics_provider_unittest.cc

+++ b/chrome/browser/metrics/extensions_metrics_provider_unittest.cc

@@ -50,29 +50,31 @@ class TestExtensionsMetricsProvider : public ExtensionsMetricsProvider {

new extensions::ExtensionSet());

scoped_refptr<const extensions::Extension> extension;

extension = extensions::ExtensionBuilder()

- .SetManifest(std::move(extensions::DictionaryBuilder()

- .Set("name", "Test extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(extensions::DictionaryBuilder()

+ .Set("name", "Test extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.SetID("ahfgeienlihckogmohjhadlkjgocpleb")

.Build();

extensions->Insert(extension);

extension = extensions::ExtensionBuilder()

- .SetManifest(std::move(extensions::DictionaryBuilder()

- .Set("name", "Test extension 2")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(extensions::DictionaryBuilder()

+ .Set("name", "Test extension 2")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.SetID("pknkgggnfecklokoggaggchhaebkajji")

.Build();

extensions->Insert(extension);

- extension =

- extensions::ExtensionBuilder()

- .SetManifest(std::move(extensions::DictionaryBuilder()

- .Set("name", "Colliding Extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

- .SetID("mdhofdjgenpkhlmddfaegdjddcecipmo")

- .Build();

+ extension = extensions::ExtensionBuilder()

+ .SetManifest(extensions::DictionaryBuilder()

+ .Set("name", "Colliding Extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

+ .SetID("mdhofdjgenpkhlmddfaegdjddcecipmo")

+ .Build();

extensions->Insert(extension);

return extensions;

}