Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1904)

Unified Diff: chrome/browser/extensions/webstore_startup_installer_browsertest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_startup_installer_browsertest.cc
diff --git a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc
index 0f8accdc821f752fe3524e801e2c0545ce2b0d41..c5a6bb008d7980726d44daa33b8e5c2b3f0b7f80 100644
--- a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc
+++ b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc
@@ -141,19 +141,21 @@ IN_PROC_BROWSER_TEST_F(WebstoreStartupInstallerTest, InstallFromHostedApp) {
// app to run on a declared URL, but we don't know the port ahead of time.
scoped_refptr<const Extension> hosted_app =
ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "hosted app")
.Set("version", "1")
- .Set("app",
- std::move(
- DictionaryBuilder()
- .Set("urls", std::move(ListBuilder().Append(
- kInstallUrl.spec())))
- .Set("launch",
- std::move(DictionaryBuilder().Set(
- "web_url", kInstallUrl.spec())))))
- .Set("manifest_version", 2)))
+ .Set(
+ "app",
+ DictionaryBuilder()
+ .Set("urls",
+ ListBuilder().Append(kInstallUrl.spec()).Build())
+ .Set("launch", DictionaryBuilder()
+ .Set("web_url", kInstallUrl.spec())
+ .Build())
+ .Build())
+ .Set("manifest_version", 2)
+ .Build())
.Build();
ASSERT_TRUE(hosted_app.get());

Powered by Google App Engine
This is Rietveld 408576698