Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: chrome/browser/extensions/scripting_permissions_modifier_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
diff --git a/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc b/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
index 55add1c0fe8eb6f1d4381eaa46c3cee9639a2b28..7ef41e83a31de554f735ed7a5c2d7d68f9fab4aa 100644
--- a/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
+++ b/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
@@ -42,20 +42,20 @@ scoped_refptr<const Extension> CreateExtensionWithPermissions(
}
DictionaryBuilder script;
- script.Set("matches", std::move(scriptable_host_list))
- .Set("js", std::move(ListBuilder().Append("foo.js")));
+ script.Set("matches", scriptable_host_list.Build())
+ .Set("js", ListBuilder().Append("foo.js").Build());
return ExtensionBuilder()
.SetLocation(location)
- .SetManifest(
- std::move(DictionaryBuilder()
- .Set("name", name)
- .Set("description", "foo")
- .Set("manifest_version", 2)
- .Set("version", "0.1.2.3")
- .Set("content_scripts",
- std::move(ListBuilder().Append(std::move(script))))
- .Set("permissions", std::move(explicit_host_list))))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", name)
+ .Set("description", "foo")
+ .Set("manifest_version", 2)
+ .Set("version", "0.1.2.3")
+ .Set("content_scripts",
+ ListBuilder().Append(script.Build()).Build())
+ .Set("permissions", explicit_host_list.Build())
+ .Build())
.SetID(crx_file::id_util::GenerateId(name))
.Build();
}

Powered by Google App Engine
This is Rietveld 408576698