Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/extensions/process_manager_browsertest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/process_manager_browsertest.cc
diff --git a/chrome/browser/extensions/process_manager_browsertest.cc b/chrome/browser/extensions/process_manager_browsertest.cc
index 5608012834ddefed065e489b4341f5c1ca393152..6a0190913b0711aeecaab644fb485f743d99220c 100644
--- a/chrome/browser/extensions/process_manager_browsertest.cc
+++ b/chrome/browser/extensions/process_manager_browsertest.cc
@@ -105,13 +105,14 @@ class ProcessManagerBrowserTest : public ExtensionBrowserTest {
.Set("content_security_policy",
"script-src 'self' 'unsafe-eval'; object-src 'self'")
.Set("sandbox",
- std::move(DictionaryBuilder().Set(
- "pages", std::move(ListBuilder().Append("sandboxed.html")))))
- .Set("web_accessible_resources", std::move(ListBuilder().Append("*")));
+ DictionaryBuilder()
+ .Set("pages", ListBuilder().Append("sandboxed.html").Build())
+ .Build())
+ .Set("web_accessible_resources", ListBuilder().Append("*").Build());
if (has_background_process) {
manifest.Set("background",
- std::move(DictionaryBuilder().Set("page", "bg.html")));
+ DictionaryBuilder().Set("page", "bg.html").Build());
dir->WriteFile(FILE_PATH_LITERAL("bg.html"),
"<iframe id='bgframe' src='empty.html'></iframe>");
}

Powered by Google App Engine
This is Rietveld 408576698