Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3197)

Unified Diff: chrome/browser/extensions/extension_install_prompt_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt_unittest.cc
diff --git a/chrome/browser/extensions/extension_install_prompt_unittest.cc b/chrome/browser/extensions/extension_install_prompt_unittest.cc
index 0b53071b411fe86aebc75e66a18a07c17d9391ab..64b095a7941702d526c0ed600a79e485287f6bff 100644
--- a/chrome/browser/extensions/extension_install_prompt_unittest.cc
+++ b/chrome/browser/extensions/extension_install_prompt_unittest.cc
@@ -103,11 +103,12 @@ TEST_F(ExtensionInstallPromptUnitTest, PromptShowsPermissionWarnings) {
URLPatternSet(), URLPatternSet()));
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "foo")
- .Set("version", "1.0")
- .Set("manifest_version", 2)
- .Set("description", "Random Ext")))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "foo")
+ .Set("version", "1.0")
+ .Set("manifest_version", 2)
+ .Set("description", "Random Ext")
+ .Build())
.Build();
content::TestWebContentsFactory factory;
@@ -132,16 +133,17 @@ TEST_F(ExtensionInstallPromptUnitTest, PromptShowsWithheldPermissions) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
.SetManifest(
- std::move(DictionaryBuilder()
- .Set("name", "foo")
- .Set("version", "1.0")
- .Set("manifest_version", 2)
- .Set("description", "Random Ext")
- .Set("permissions",
- std::move(ListBuilder()
- .Append("http://*/*")
- .Append("http://www.google.com/")
- .Append("tabs")))))
+ DictionaryBuilder()
+ .Set("name", "foo")
+ .Set("version", "1.0")
+ .Set("manifest_version", 2)
+ .Set("description", "Random Ext")
+ .Set("permissions", ListBuilder()
+ .Append("http://*/*")
+ .Append("http://www.google.com/")
+ .Append("tabs")
+ .Build())
+ .Build())
.Build();
content::TestWebContentsFactory factory;
@@ -162,16 +164,16 @@ TEST_F(ExtensionInstallPromptUnitTest,
DelegatedPromptShowsOptionalPermissions) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(
- DictionaryBuilder()
- .Set("name", "foo")
- .Set("version", "1.0")
- .Set("manifest_version", 2)
- .Set("description", "Random Ext")
- .Set("permissions",
- std::move(ListBuilder().Append("clipboardRead")))
- .Set("optional_permissions",
- std::move(ListBuilder().Append("tabs")))))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "foo")
+ .Set("version", "1.0")
+ .Set("manifest_version", 2)
+ .Set("description", "Random Ext")
+ .Set("permissions",
+ ListBuilder().Append("clipboardRead").Build())
+ .Set("optional_permissions",
+ ListBuilder().Append("tabs").Build())
+ .Build())
.Build();
content::TestWebContentsFactory factory;

Powered by Google App Engine
This is Rietveld 408576698