Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

chrome/browser/extensions/extension_install_prompt_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/macros.h"
@@ skipping 85 matching lines @@
 }  // namespace
 
 TEST_F(ExtensionInstallPromptUnitTest, PromptShowsPermissionWarnings) {
   APIPermissionSet api_permissions;
   api_permissions.insert(APIPermission::kTab);
   scoped_ptr<const PermissionSet> permission_set(
       new PermissionSet(api_permissions, ManifestPermissionSet(),
                         URLPatternSet(), URLPatternSet()));
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
-          .SetManifest(std::move(DictionaryBuilder()
-                                     .Set("name", "foo")
-                                     .Set("version", "1.0")
-                                     .Set("manifest_version", 2)
-                                     .Set("description", "Random Ext")))
+          .SetManifest(DictionaryBuilder()
+                           .Set("name", "foo")
+                           .Set("version", "1.0")
+                           .Set("manifest_version", 2)
+                           .Set("description", "Random Ext")
+                           .Build())
           .Build();
 
   content::TestWebContentsFactory factory;
   ExtensionInstallPrompt prompt(factory.CreateWebContents(profile()));
   base::RunLoop run_loop;
   prompt.ShowDialog(
       ExtensionInstallPrompt::DoneCallback(), extension.get(), nullptr,
       make_scoped_ptr(new ExtensionInstallPrompt::Prompt(
           ExtensionInstallPrompt::PERMISSIONS_PROMPT)),
       std::move(permission_set),
       base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),
                  1u,    // |regular_permissions_count|.
                  0u));  // |withheld_permissions_count|.
   run_loop.Run();
 }
 
 TEST_F(ExtensionInstallPromptUnitTest, PromptShowsWithheldPermissions) {
   // Enable consent flag so that <all_hosts> permissions get withheld.
   FeatureSwitch::ScopedOverride enable_scripts_switch(
       FeatureSwitch::scripts_require_action(), true);
 
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
           .SetManifest(
-              std::move(DictionaryBuilder()
-                            .Set("name", "foo")
-                            .Set("version", "1.0")
-                            .Set("manifest_version", 2)
-                            .Set("description", "Random Ext")
-                            .Set("permissions",
-                                 std::move(ListBuilder()
-                                               .Append("http://*/*")
-                                               .Append("http://www.google.com/")
-                                               .Append("tabs")))))
+              DictionaryBuilder()
+                  .Set("name", "foo")
+                  .Set("version", "1.0")
+                  .Set("manifest_version", 2)
+                  .Set("description", "Random Ext")
+                  .Set("permissions", ListBuilder()
+                                          .Append("http://*/*")
+                                          .Append("http://www.google.com/")
+                                          .Append("tabs")
+                                          .Build())
+                  .Build())
           .Build();
 
   content::TestWebContentsFactory factory;
   ExtensionInstallPrompt prompt(factory.CreateWebContents(profile()));
   base::RunLoop run_loop;
 
   // We expect <all_hosts> to be withheld, but http://www.google.com/ and tabs
   // permissions should be granted as regular permissions.
   prompt.ShowDialog(
       ExtensionInstallPrompt::DoneCallback(), extension.get(), nullptr,
       base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),
                  2u,    // |regular_permissions_count|.
                  1u));  // |withheld_permissions_count|.
   run_loop.Run();
 }
 
 TEST_F(ExtensionInstallPromptUnitTest,
        DelegatedPromptShowsOptionalPermissions) {
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
-          .SetManifest(std::move(
-              DictionaryBuilder()
-                  .Set("name", "foo")
-                  .Set("version", "1.0")
-                  .Set("manifest_version", 2)
-                  .Set("description", "Random Ext")
-                  .Set("permissions",
-                       std::move(ListBuilder().Append("clipboardRead")))
-                  .Set("optional_permissions",
-                       std::move(ListBuilder().Append("tabs")))))
+          .SetManifest(DictionaryBuilder()
+                           .Set("name", "foo")
+                           .Set("version", "1.0")
+                           .Set("manifest_version", 2)
+                           .Set("description", "Random Ext")
+                           .Set("permissions",
+                                ListBuilder().Append("clipboardRead").Build())
+                           .Set("optional_permissions",
+                                ListBuilder().Append("tabs").Build())
+                           .Build())
           .Build();
 
   content::TestWebContentsFactory factory;
   ExtensionInstallPrompt prompt(factory.CreateWebContents(profile()));
   base::RunLoop run_loop;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> sub_prompt(
       new ExtensionInstallPrompt::Prompt(
           ExtensionInstallPrompt::DELEGATED_PERMISSIONS_PROMPT));
   sub_prompt->set_delegated_username("Username");
@@ skipping 51 matching lines @@
     prompt.ShowDialog(ExtensionInstallPrompt::DoneCallback(),
                       extension,
                       app_icon.bitmap(),  // Use a different icon.
                       base::Bind(&VerifyPromptIconCallback,
                                  run_loop.QuitClosure(), *app_icon.bitmap()));
     run_loop.Run();
   }
 }
 
 }  // namespace extensions