chrome/browser/extensions/extension_context_menu_model_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/extension_action_test_util.cc ('k') | chrome/browser/extensions/extension_install_prompt_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_context_menu_model_unittest.cc

diff --git a/chrome/browser/extensions/extension_context_menu_model_unittest.cc b/chrome/browser/extensions/extension_context_menu_model_unittest.cc

index 4c14525ddb7ca49a2ee009b5a120faca7bcf2ee0..19951e05548d77e3dde5e2a53c573ca0939e0649 100644

--- a/chrome/browser/extensions/extension_context_menu_model_unittest.cc

+++ b/chrome/browser/extensions/extension_context_menu_model_unittest.cc

@@ -160,13 +160,12 @@ const Extension* ExtensionContextMenuModelTest::AddExtensionWithHostPermission(

manifest.Set("name", name)

.Set("version", "1")

.Set("manifest_version", 2)

- .Set(action_key, DictionaryBuilder());

+ .Set(action_key, DictionaryBuilder().Build());

if (!host_permission.empty())

- manifest.Set("permissions",

- std::move(ListBuilder().Append(host_permission)));

+ manifest.Set("permissions", ListBuilder().Append(host_permission).Build());

scoped_refptr<const Extension> extension =

ExtensionBuilder()

- .SetManifest(std::move(manifest))

+ .SetManifest(manifest.Build())

.SetID(crx_file::id_util::GenerateId(name))

.SetLocation(location)

.Build();

@@ -234,7 +233,7 @@ TEST_F(ExtensionContextMenuModelTest, ComponentExtensionContextMenu) {

.Set("name", name)

.Set("version", "1")

.Set("manifest_version", 2)

- .Set("browser_action", DictionaryBuilder())

+ .Set("browser_action", DictionaryBuilder().Build())

.Build();

{