Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/extensions/extension_action_test_util.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_test_util.cc
diff --git a/chrome/browser/extensions/extension_action_test_util.cc b/chrome/browser/extensions/extension_action_test_util.cc
index b8603317bfbf5488cfb5e87054d83cf1ca7bb0c6..e622d8e3d9967342e88158ca9d1c5dafaf6de63e 100644
--- a/chrome/browser/extensions/extension_action_test_util.cc
+++ b/chrome/browser/extensions/extension_action_test_util.cc
@@ -150,10 +150,10 @@ scoped_refptr<const Extension> CreateActionExtension(
}
if (action_key)
- manifest.Set(action_key, DictionaryBuilder());
+ manifest.Set(action_key, DictionaryBuilder().Build());
return ExtensionBuilder()
- .SetManifest(std::move(manifest))
+ .SetManifest(manifest.Build())
.SetID(crx_file::id_util::GenerateId(name))
.SetLocation(location)
.Build();

Powered by Google App Engine
This is Rietveld 408576698