Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/browser/chromeos/power/renderer_freezer_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/power/renderer_freezer_unittest.cc
diff --git a/chrome/browser/chromeos/power/renderer_freezer_unittest.cc b/chrome/browser/chromeos/power/renderer_freezer_unittest.cc
index 28316573d297a9422675125d9abafb9d2f68b1e7..c1c48efa66e525ea2096010bc39d36ac3f801028 100644
--- a/chrome/browser/chromeos/power/renderer_freezer_unittest.cc
+++ b/chrome/browser/chromeos/power/renderer_freezer_unittest.cc
@@ -312,20 +312,23 @@ TEST_F(RendererFreezerTestWithExtensions, DoesNotFreezeGcmExtensionRenderers) {
// First build the GCM extension.
scoped_refptr<extensions::Extension> gcm_app =
extensions::ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
extensions::DictionaryBuilder()
.Set("name", "GCM App")
.Set("version", "1.0.0")
.Set("manifest_version", 2)
.Set("app",
- std::move(extensions::DictionaryBuilder().Set(
- "background",
- std::move(extensions::DictionaryBuilder().Set(
- "scripts",
- std::move(extensions::ListBuilder().Append(
- "background.js")))))))
+ extensions::DictionaryBuilder()
+ .Set("background",
+ extensions::DictionaryBuilder()
+ .Set("scripts", extensions::ListBuilder()
+ .Append("background.js")
+ .Build())
+ .Build())
+ .Build())
.Set("permissions",
- std::move(extensions::ListBuilder().Append("gcm")))))
+ extensions::ListBuilder().Append("gcm").Build())
+ .Build())
.Build();
// Now install it and give it a renderer.
@@ -345,18 +348,21 @@ TEST_F(RendererFreezerTestWithExtensions, FreezesNonGcmExtensionRenderers) {
// First build the extension.
scoped_refptr<extensions::Extension> background_app =
extensions::ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
extensions::DictionaryBuilder()
.Set("name", "Background App")
.Set("version", "1.0.0")
.Set("manifest_version", 2)
.Set("app",
- std::move(extensions::DictionaryBuilder().Set(
- "background",
- std::move(extensions::DictionaryBuilder().Set(
- "scripts",
- std::move(extensions::ListBuilder().Append(
- "background.js")))))))))
+ extensions::DictionaryBuilder()
+ .Set("background",
+ extensions::DictionaryBuilder()
+ .Set("scripts", extensions::ListBuilder()
+ .Append("background.js")
+ .Build())
+ .Build())
+ .Build())
+ .Build())
.Build();
// Now install it and give it a renderer.

Powered by Google App Engine
This is Rietveld 408576698