Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: chrome/browser/chromeos/power/extension_event_observer_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/power/extension_event_observer_unittest.cc
diff --git a/chrome/browser/chromeos/power/extension_event_observer_unittest.cc b/chrome/browser/chromeos/power/extension_event_observer_unittest.cc
index dfd58c15c5b7d6d7134180f43c2b417ce21da3c0..35f1e2d546f3a61a21dd8f1dfe1b165a4d534ee2 100644
--- a/chrome/browser/chromeos/power/extension_event_observer_unittest.cc
+++ b/chrome/browser/chromeos/power/extension_event_observer_unittest.cc
@@ -90,21 +90,24 @@ class ExtensionEventObserverTest : public ::testing::Test {
bool uses_gcm) {
scoped_refptr<extensions::Extension> app =
extensions::ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
extensions::DictionaryBuilder()
.Set("name", name)
.Set("version", "1.0.0")
.Set("manifest_version", 2)
- .Set("app",
- std::move(extensions::DictionaryBuilder().Set(
- "background",
- std::move(extensions::DictionaryBuilder().Set(
- "scripts",
- std::move(extensions::ListBuilder().Append(
- "background.js")))))))
- .Set("permissions",
- std::move(extensions::ListBuilder().Append(
- uses_gcm ? "gcm" : "")))))
+ .Set("app", extensions::DictionaryBuilder()
+ .Set("background",
+ extensions::DictionaryBuilder()
+ .Set("scripts",
+ extensions::ListBuilder()
+ .Append("background.js")
+ .Build())
+ .Build())
+ .Build())
+ .Set("permissions", extensions::ListBuilder()
+ .Append(uses_gcm ? "gcm" : "")
+ .Build())
+ .Build())
.Build();
created_apps_.push_back(app);

Powered by Google App Engine
This is Rietveld 408576698