Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1739033002: Revert of command_buffer_gles2: Implement EGL default Display as a global object (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
Reviewers:
Kimmo Kinnunen, Nico, piman
CC:
chromium-reviews, piman+watch_chromium.org, Sami Väisänen
Base URL:
https://chromium.googlesource.com/chromium/src.git@command_buffer_gles2-multiple-contexts
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of command_buffer_gles2: Implement EGL default Display as a global object (patchset #8 id:140001 of https://codereview.chromium.org/1714883002/ ) Reason for revert: Broke gles2_conform on mac/linux GPU bots on FYI waterfall GTFNativeCreateWindow failed Original issue's description: > command_buffer_gles2: Implement EGL default Display as a global object > > Make EGL Display a global. eglGetDisplay(EGL_DEFAULT_DISPLAY) will > return the same object. > > Store EGL state in a new thread-local object (ThreadState). One > display, multiple surfaces, multiple contexts. > > Fix the currently implemented entry points to return specified errors > and behave as specified. Notable changes: > * eglGetDisplay() does not create new displays for each invocation > * eglTerminate() invalidates the created egl objects but leaves the > current context intact as specified > * eglMakeCurrent() is implemented more correctly with refcount semantics > * eglQueryStrings() works without display for some names > * eglReleaseThread() is implemeted > * Config are now separate for pbuffers and windows, so that contexts > can be created separate from surfaces > * Context can be made current with different surfaces > * Catches errors related to context being set current to multiple > threads > * Tries to be thread-safe > > In the implementation, the Display contains a lock ensuring all thread > accesses are consistent. All functions using or changing thread-local > state have explicit egl::ThreadState parameter. > > BUG=581634 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/de9aa3be41bca094454babbd62907815fad7f5c2 > Cr-Commit-Position: refs/heads/master@{#377535} TBR=piman@chromium.org,thakis@chromium.org,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581634 Committed: https://crrev.com/0df7774c8d57adb794693f98733c610715c0879c Cr-Commit-Position: refs/heads/master@{#377641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+774 lines, -1988 lines) Patch
M gpu/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +1 line, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/egl_test.cc View 1 chunk +11 lines, -569 lines 0 comments Download
M gpu/gles2_conform_support/egl/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/gles2_conform_support/egl/config.h View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/egl/config.cc View 3 chunks +2 lines, -72 lines 0 comments Download
D gpu/gles2_conform_support/egl/context.h View 1 chunk +0 lines, -120 lines 0 comments Download
D gpu/gles2_conform_support/egl/context.cc View 1 chunk +0 lines, -390 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +91 lines, -56 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 3 chunks +355 lines, -323 lines 0 comments Download
M gpu/gles2_conform_support/egl/egl.cc View 6 chunks +297 lines, -99 lines 0 comments Download
M gpu/gles2_conform_support/egl/surface.h View 1 chunk +8 lines, -17 lines 0 comments Download
M gpu/gles2_conform_support/egl/surface.cc View 1 chunk +2 lines, -29 lines 0 comments Download
D gpu/gles2_conform_support/egl/thread_state.h View 1 chunk +0 lines, -70 lines 0 comments Download
D gpu/gles2_conform_support/egl/thread_state.cc View 1 chunk +0 lines, -199 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/gles2_conform_support/native/egl_native_windowless.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Zhenyao Mo
Created Revert of command_buffer_gles2: Implement EGL default Display as a global object
4 years, 10 months ago (2016-02-25 19:14:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739033002/1
4 years, 10 months ago (2016-02-25 19:17:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 19:24:47 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 19:26:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0df7774c8d57adb794693f98733c610715c0879c
Cr-Commit-Position: refs/heads/master@{#377641}

Powered by Google App Engine
This is Rietveld 408576698