Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1740483004: Rename enums/functions that collide in chromium style in core/html/. (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
Reviewers:
pdr., esprehn, DaleCurtis
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gavinp+prerender_chromium.org, gasubic, jam, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, pdr+renderingwatchlist_chromium.org, philipj_slow, piman, posciak+watch_chromium.org, rwlbuis, sof, nessy, szager+layoutwatch_chromium.org, tfarina, Nico, vcarbune.chromium, webcomponents-bugzilla_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@get-names-5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename enums/functions that collide in chromium style in core/html/. R=esprehn@chromium.org, pdr BUG=582312 Committed: https://crrev.com/13afe0362f2e09a1bce83cef531a8b25d83b8ffe Cr-Commit-Position: refs/heads/master@{#378055}

Patch Set 1 #

Patch Set 2 : get-names-6: rebase #

Patch Set 3 : get-names-6: . #

Patch Set 4 : get-names-6: . #

Patch Set 5 : get-names-6: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -186 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/html_video_element_capturer_source_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkManifest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttribute.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttributeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkResource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaError.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/CompactHTMLToken.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLToken.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 43 chunks +72 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SpinButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVideo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740483004/1
4 years, 10 months ago (2016-02-25 20:03:27 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/27275) android_chromium_gn_compile_dbg on ...
4 years, 10 months ago (2016-02-25 20:07:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740483004/40001
4 years, 10 months ago (2016-02-26 00:03:45 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/27513) linux_android_rel_ng on ...
4 years, 10 months ago (2016-02-26 00:53:42 UTC) #8
danakj
4 years, 10 months ago (2016-02-26 02:46:34 UTC) #9
danakj
+dalecurtis for media (trivial, will TBR you)
4 years, 10 months ago (2016-02-26 02:47:04 UTC) #11
DaleCurtis
media/ lgtm
4 years, 10 months ago (2016-02-26 03:01:49 UTC) #12
pdr.
On 2016/02/26 at 03:01:49, dalecurtis wrote: > media/ lgtm LGTM 2
4 years, 10 months ago (2016-02-26 04:34:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740483004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740483004/80001
4 years, 10 months ago (2016-02-26 19:08:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/173024)
4 years, 10 months ago (2016-02-26 20:39:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740483004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740483004/80001
4 years, 10 months ago (2016-02-26 23:55:40 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-27 01:22:59 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 01:25:10 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/13afe0362f2e09a1bce83cef531a8b25d83b8ffe
Cr-Commit-Position: refs/heads/master@{#378055}

Powered by Google App Engine
This is Rietveld 408576698