third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp - Issue 1738623004: Rename enums/functions that collide in chromium style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

Issue 1738623004: Rename enums/functions that collide in chromium style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-names-4

Patch Set: get-names-5: rebase-and-stuff Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLImageElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

index 9768137d55eeb324d4e67b08a0fc0a0236e2956d..99ae9ddfa904b589181265605caebeb818128d42 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

@@ -28,9 +28,9 @@ TEST_F(HTMLImageElementTest, width)

RefPtrWillBeRawPtr<HTMLImageElement> image = HTMLImageElement::create(m_dummyPageHolder->document(), nullptr, /* createdByParser */ false);

image->setAttribute(HTMLNames::widthAttr, "400");

// TODO(yoav): `width` does not impact resourceWidth until we resolve https://github.com/ResponsiveImagesCG/picture-element/issues/268

- EXPECT_EQ(500, image->resourceWidth().width);

+ EXPECT_EQ(500, image->getResourceWidth().width);

image->setAttribute(HTMLNames::sizesAttr, "100vw");

- EXPECT_EQ(500, image->resourceWidth().width);

+ EXPECT_EQ(500, image->getResourceWidth().width);

}

TEST_F(HTMLImageElementTest, sourceSize)