[wasm] Int64Lowering of FXXXConvertI64 instructions.

[wasm] Int64Lowering of FXXXConvertI64 instructions.

On 32-bit systems FXXXConvertI64 instructions are compiled to calls to
C functions. The TF node for the function call is already generated in
the wasm compiler, the lowering of the I64 parameter is done in the
Int64Lowering.

R=titzer@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/b1e345905af9298acb088035b8c845dbfa36a8e8
Cr-Commit-Position: refs/heads/master@{#34487}

[Yang, 2016-02-25 14:23:34]

serializer lgtm.

[titzer, 2016-02-25 17:04:33]

https://codereview.chromium.org/1738623003/diff/40001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1738623003/diff/40001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:1508: MachineRepresentation
parameter_representation =
You can shorten this code up a bit by inlining the parameter_representation and
result_type locals.

https://codereview.chromium.org/1738623003/diff/40001/test/cctest/compiler/te...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1738623003/diff/40001/test/cctest/compiler/te...
test/cctest/compiler/test-run-machops.cc:5657: void
TestExternalReferenceRoundingFunction(
Can we split all these external references tests into a separate file? Because
they don't correspond directly to machine operators, they just call external
references.

[ahaas, 2016-02-25 18:29:19]

https://codereview.chromium.org/1738623003/diff/40001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1738623003/diff/40001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:1508: MachineRepresentation
parameter_representation =
On 2016/02/25 at 17:04:33, titzer wrote:
> You can shorten this code up a bit by inlining the parameter_representation
and result_type locals.

Done.

https://codereview.chromium.org/1738623003/diff/40001/test/cctest/compiler/te...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1738623003/diff/40001/test/cctest/compiler/te...
test/cctest/compiler/test-run-machops.cc:5657: void
TestExternalReferenceRoundingFunction(
On 2016/02/25 at 17:04:33, titzer wrote:
> Can we split all these external references tests into a separate file? Because
they don't correspond directly to machine operators, they just call external
references.

Done.

[titzer, 2016-02-28 15:26:03]

Looks good other than splitting out the assembler changes to a src/wasm file.

https://codereview.chromium.org/1738623003/diff/130001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/1738623003/diff/130001/src/assembler.cc#newco...
src/assembler.cc:1150: static void wasm_f32_trunc_wrapper(float* param) { *param
= truncf(*param); }
Can we extract these wrappers to a header/cc file pair in
src/wasm/wasm-external-refs.(h|cc)? Then you can use a namespace instead of a
prefix as well.

https://codereview.chromium.org/1738623003/diff/130001/src/compiler/wasm-comp...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1738623003/diff/130001/src/compiler/wasm-comp...
src/compiler/wasm-compiler.cc:1542: Signature<MachineType>::Builder
sig_builder(jsgraph()->zone(), 0, 2);
I think you can use the type alias MachineSignature here.

[ahaas, 2016-03-02 14:02:56]

https://codereview.chromium.org/1738623003/diff/130001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/1738623003/diff/130001/src/assembler.cc#newco...
src/assembler.cc:1150: static void wasm_f32_trunc_wrapper(float* param) { *param
= truncf(*param); }
On 2016/02/28 at 15:26:03, titzer wrote:
> Can we extract these wrappers to a header/cc file pair in
src/wasm/wasm-external-refs.(h|cc)? Then you can use a namespace instead of a
prefix as well.

Done.
I only extracted the static functions, the other functions need the private
"Redirect" function. I didn't introduce wasm-external-refs.cc because
wasm-external-refs.h is only included in assembler.cc.

https://codereview.chromium.org/1738623003/diff/130001/src/compiler/wasm-comp...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1738623003/diff/130001/src/compiler/wasm-comp...
src/compiler/wasm-compiler.cc:1542: Signature<MachineType>::Builder
sig_builder(jsgraph()->zone(), 0, 2);
On 2016/02/28 at 15:26:03, titzer wrote:
> I think you can use the type alias MachineSignature here.

Done. I just don't like typedef too much.

[titzer, 2016-03-02 14:06:20]

https://codereview.chromium.org/1738623003/diff/130001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/1738623003/diff/130001/src/assembler.cc#newco...
src/assembler.cc:1150: static void wasm_f32_trunc_wrapper(float* param) { *param
= truncf(*param); }
On 2016/03/02 14:02:56, ahaas wrote:
> On 2016/02/28 at 15:26:03, titzer wrote:
> > Can we extract these wrappers to a header/cc file pair in
> src/wasm/wasm-external-refs.(h|cc)? Then you can use a namespace instead of a
> prefix as well.
> 
> Done.
> I only extracted the static functions, the other functions need the private
> "Redirect" function. I didn't introduce wasm-external-refs.cc because
> wasm-external-refs.h is only included in assembler.cc.

The goal there is to introduce an interface between the assembler and wasm,
instead of a large number of wasm-only functions directly in the assembler. So,
it's not a problem if it's only included in one place.

[titzer, 2016-03-04 02:15:06]

lgtm

[ahaas, 2016-03-04 09:45:02]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-04 09:45:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1738623003/#ps310001
(title: "rebase.")

[commit-bot: I haz the power, 2016-03-04 09:45:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738623003/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738623003/310001

[commit-bot: I haz the power, 2016-03-04 09:50:53]

Committed patchset #17 (id:310001)

[commit-bot: I haz the power, 2016-03-04 09:51:53]

Description was changed from

==========
[wasm] Int64Lowering of FXXXConvertI64 instructions.

On 32-bit systems FXXXConvertI64 instructions are compiled to calls to
C functions. The TF node for the function call is already generated in
the wasm compiler, the lowering of the I64 parameter is done in the
Int64Lowering.

R=titzer@chromium.org, yangguo@chromium.org
==========

to

==========
[wasm] Int64Lowering of FXXXConvertI64 instructions.

On 32-bit systems FXXXConvertI64 instructions are compiled to calls to
C functions. The TF node for the function call is already generated in
the wasm compiler, the lowering of the I64 parameter is done in the
Int64Lowering.

R=titzer@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/b1e345905af9298acb088035b8c845dbfa36a8e8
Cr-Commit-Position: refs/heads/master@{#34487}
==========

[commit-bot: I haz the power, 2016-03-04 09:51:54]

Patchset 17 (id:??) landed as
https://crrev.com/b1e345905af9298acb088035b8c845dbfa36a8e8
Cr-Commit-Position: refs/heads/master@{#34487}