Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1737873003: Revert of Make Intl install properties more like how other builtins do (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make Intl install properties more like how other builtins do (patchset #1 id:1 of https://codereview.chromium.org/1733293003/ ) Reason for revert: Breaks a bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/6812 Original issue's description: > Make Intl install properties more like how other builtins do > > Intl has been somewhat of an oddball for how it integrates with V8. > One aspect is that it largely didn't use utils to install itself > into the snapshot, which led to some missing names, which new > test262 tests check for, and duplicated code. This patch brings > Intl a bit closer to how the rest of the builtins do things, though > not entirely as it is currently structured to do unusual things, > such as creating new constructors from JavaScript rather than C++. > New test262 tests check for some of the names that are added in > this patch. > > R=adamk > CC=jshin > BUG=v8:4778 > LOG=Y > > Committed: https://crrev.com/a40830577d80f699282dd83864619656b7a7966c > Cr-Commit-Position: refs/heads/master@{#34311} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4778 Committed: https://crrev.com/829f951aaeee6548e79d735a442be1c9f02a83e4 Cr-Commit-Position: refs/heads/master@{#34314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -196 lines) Patch
M src/js/i18n.js View 23 chunks +229 lines, -196 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dan Ehrenberg
Created Revert of Make Intl install properties more like how other builtins do
4 years, 10 months ago (2016-02-26 05:25:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737873003/1
4 years, 10 months ago (2016-02-26 05:25:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 05:26:26 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 05:27:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/829f951aaeee6548e79d735a442be1c9f02a83e4
Cr-Commit-Position: refs/heads/master@{#34314}

Powered by Google App Engine
This is Rietveld 408576698