Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1733293003: Make Intl install properties more like how other builtins do (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Intl install properties more like how other builtins do Intl has been somewhat of an oddball for how it integrates with V8. One aspect is that it largely didn't use utils to install itself into the snapshot, which led to some missing names, which new test262 tests check for, and duplicated code. This patch brings Intl a bit closer to how the rest of the builtins do things, though not entirely as it is currently structured to do unusual things, such as creating new constructors from JavaScript rather than C++. New test262 tests check for some of the names that are added in this patch. R=adamk CC=jshin BUG=v8:4778 LOG=Y Committed: https://crrev.com/a40830577d80f699282dd83864619656b7a7966c Cr-Commit-Position: refs/heads/master@{#34311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -135 lines) Patch
M src/js/i18n.js View 23 chunks +102 lines, -135 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Dan Ehrenberg
4 years, 10 months ago (2016-02-26 02:50:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733293003/1
4 years, 10 months ago (2016-02-26 02:50:36 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11539)
4 years, 10 months ago (2016-02-26 02:54:23 UTC) #6
adamk
lgtm
4 years, 10 months ago (2016-02-26 04:32:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733293003/1
4 years, 10 months ago (2016-02-26 04:38:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 04:40:57 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a40830577d80f699282dd83864619656b7a7966c Cr-Commit-Position: refs/heads/master@{#34311}
4 years, 10 months ago (2016-02-26 04:41:55 UTC) #13
Dan Ehrenberg
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1737873003/ by littledan@chromium.org. ...
4 years, 10 months ago (2016-02-26 05:25:30 UTC) #14
Dan Ehrenberg
4 years, 10 months ago (2016-02-26 19:19:12 UTC) #15
Message was sent while issue was closed.
On 2016/02/26 at 05:25:30, Dan Ehrenberg wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1737873003/ by littledan@chromium.org.
> 
> The reason for reverting is: Breaks a bot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/build....

Reland: https://codereview.chromium.org/1745483002/

Powered by Google App Engine
This is Rietveld 408576698