Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1737653002: Update shaderc lib and use single combined lib (Closed)

Created:
4 years, 10 months ago by egdaniel
Modified:
4 years, 10 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -124 lines) Patch
M gyp/gpu.gyp View 1 chunk +1 line, -7 lines 0 comments Download
M src/gpu/vk/GrVkProgramBuilder.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
D third_party/shaderc/Debug/OGLCompiler.lib View Binary file 0 comments Download
D third_party/shaderc/Debug/OSDependent.lib View Binary file 0 comments Download
D third_party/shaderc/Debug/SPIRV.lib View Binary file 0 comments Download
D third_party/shaderc/Debug/SPIRV-Tools.lib View Binary file 0 comments Download
D third_party/shaderc/Debug/glslang.lib View Binary file 0 comments Download
D third_party/shaderc/Debug/shaderc.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/shaderc_combined.lib View Binary file 0 comments Download
D third_party/shaderc/Debug/shaderc_util.lib View Binary file 0 comments Download
D third_party/shaderc/Release/OGLCompiler.lib View Binary file 0 comments Download
D third_party/shaderc/Release/OSDependent.lib View Binary file 0 comments Download
D third_party/shaderc/Release/SPIRV.lib View Binary file 0 comments Download
D third_party/shaderc/Release/SPIRV-Tools.lib View Binary file 0 comments Download
D third_party/shaderc/Release/glslang.lib View Binary file 0 comments Download
D third_party/shaderc/Release/shaderc.lib View Binary file 0 comments Download
A + third_party/shaderc/Release/shaderc_combined.lib View Binary file 0 comments Download
D third_party/shaderc/Release/shaderc_util.lib View Binary file 0 comments Download
M third_party/shaderc/shaderc.h View 9 chunks +99 lines, -105 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
4 years, 10 months ago (2016-02-25 14:35:32 UTC) #3
jvanverth1
LGTM Any faster?
4 years, 10 months ago (2016-02-25 14:39:53 UTC) #4
egdaniel
On 2016/02/25 14:39:53, jvanverth1 wrote: > LGTM > > Any faster? Not that I can ...
4 years, 10 months ago (2016-02-25 14:41:14 UTC) #5
egdaniel
4 years, 10 months ago (2016-02-25 14:48:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d07b76405a672dced858aaa9ed475755ea13305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698