third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.cpp ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h

index 48aa6c793bc6b77866231fe4d4c2fe90f30a77f7..545c2fbd247c8943d0055a64c45a39f035955775 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h

@@ -47,14 +47,14 @@ public:

return adoptRefWillBeNoop(new DeviceOrientationEvent(eventType, orientation));

}

- void initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute);

+ void initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, bool absolute);

DeviceOrientationData* orientation() const { return m_orientation.get(); }

double alpha(bool& isNull) const;

double beta(bool& isNull) const;

double gamma(bool& isNull) const;

- bool absolute(bool& isNull) const;

+ bool absolute() const;

const AtomicString& interfaceName() const override;