Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2010, The Android Open Source Project 2 * Copyright 2010, The Android Open Source Project
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * * Redistributions of source code must retain the above copyright 7 * * Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * * Redistributions in binary form must reproduce the above copyright 9 * * Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 29 matching lines...) Expand all
40 ~DeviceOrientationEvent() override; 40 ~DeviceOrientationEvent() override;
41 static PassRefPtrWillBeRawPtr<DeviceOrientationEvent> create() 41 static PassRefPtrWillBeRawPtr<DeviceOrientationEvent> create()
42 { 42 {
43 return adoptRefWillBeNoop(new DeviceOrientationEvent); 43 return adoptRefWillBeNoop(new DeviceOrientationEvent);
44 } 44 }
45 static PassRefPtrWillBeRawPtr<DeviceOrientationEvent> create(const AtomicStr ing& eventType, DeviceOrientationData* orientation) 45 static PassRefPtrWillBeRawPtr<DeviceOrientationEvent> create(const AtomicStr ing& eventType, DeviceOrientationData* orientation)
46 { 46 {
47 return adoptRefWillBeNoop(new DeviceOrientationEvent(eventType, orientat ion)); 47 return adoptRefWillBeNoop(new DeviceOrientationEvent(eventType, orientat ion));
48 } 48 }
49 49
50 void initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute); 50 void initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, bool absolute);
51 51
52 DeviceOrientationData* orientation() const { return m_orientation.get(); } 52 DeviceOrientationData* orientation() const { return m_orientation.get(); }
53 53
54 double alpha(bool& isNull) const; 54 double alpha(bool& isNull) const;
55 double beta(bool& isNull) const; 55 double beta(bool& isNull) const;
56 double gamma(bool& isNull) const; 56 double gamma(bool& isNull) const;
57 bool absolute(bool& isNull) const; 57 bool absolute() const;
58 58
59 const AtomicString& interfaceName() const override; 59 const AtomicString& interfaceName() const override;
60 60
61 DECLARE_VIRTUAL_TRACE(); 61 DECLARE_VIRTUAL_TRACE();
62 62
63 private: 63 private:
64 DeviceOrientationEvent(); 64 DeviceOrientationEvent();
65 DeviceOrientationEvent(const AtomicString& eventType, DeviceOrientationData* ); 65 DeviceOrientationEvent(const AtomicString& eventType, DeviceOrientationData* );
66 66
67 PersistentWillBeMember<DeviceOrientationData> m_orientation; 67 PersistentWillBeMember<DeviceOrientationData> m_orientation;
68 }; 68 };
69 69
70 DEFINE_TYPE_CASTS(DeviceOrientationEvent, Event, event, event->interfaceName() = = EventNames::DeviceOrientationEvent, event.interfaceName() == EventNames::Devic eOrientationEvent); 70 DEFINE_TYPE_CASTS(DeviceOrientationEvent, Event, event, event->interfaceName() = = EventNames::DeviceOrientationEvent, event.interfaceName() == EventNames::Devic eOrientationEvent);
71 71
72 } // namespace blink 72 } // namespace blink
73 73
74 #endif // DeviceOrientationEvent_h 74 #endif // DeviceOrientationEvent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698