third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h - Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h

Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-char-

Patch Set: explain testing UUIDs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h

diff --git a/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h b/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h

index f116b9cde329466c06d223116e0521fde81fadf2..b9aef69aaf18232cd7fc901f969611ef71111dfc 100644

--- a/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h

+++ b/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h

@@ -56,6 +56,8 @@ enum class WebBluetoothError {

// SecurityError:

GATTNotAuthorized,

BlacklistedCharacteristicUUID,

+ BlacklistedRead,

+ BlacklistedWrite,

NotAllowedToAccessService,

RequestDeviceWithBlacklistedUUID,

RequestDeviceWithUniqueOrigin,