Chromium Code Reviews Chromium Code Reviews
Issue 1737423002:
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-char-| Index: third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html |
| diff --git a/third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html b/third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c9d75e3ee756994c5f43f5ec722f30de22caa70b |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html |
| @@ -0,0 +1,30 @@ |
| +<!DOCTYPE html> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="resources/bluetooth-helpers.js"></script> |
| +<script> |
| +'use strict'; |
| + |
| +test(t => { assert_true(window.testRunner instanceof Object); t.done(); }, |
| + 'window.testRunner is required for the following tests.'); |
| + |
| +promise_test(() => { |
| + testRunner.setBluetoothMockDataSet('BlacklistTestAdapter'); |
| + return requestDeviceWithKeyDown( |
| + {filters: [{services: [blacklist_test_service_uuid]}]}) |
| + .then(device => device.gatt.connect()) |
| + .then(gattServer => gattServer.getPrimaryService( |
| + blacklist_test_service_uuid)) |
| + .then(service => service.getCharacteristic( |
| + blacklist_exclude_reads_characteristic_uuid)) |
| + .then(characteristic => Promise.all( |
|
ortuno
2016/02/26 00:07:11
fwiw this wouldn't work on a real device, since yo
scheib
2016/02/26 00:49:49
Done.
|
| + [characteristic.writeValue(new Uint8Array(1 /* length */)), |
| + assert_promise_rejects_with_message( |
| + characteristic.readValue(), new DOMException( |
| + 'readValue() called on blacklisted object marked exclude-reads. ' + |
| + 'https://goo.gl/4NeimX', |
| + 'SecurityError'), |
| + 'readValue() should reject.') |
| + ])); |
| +}, 'Characteristic with exclude-reads fullfills write and rejects read.'); |
| +</script> |
