Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1737363002: fix undefined signed shifts (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
_cary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix undefined signed shifts The expression (1 << 31) is technically undefined. Fixed the undefined shift referenced by this bug and a few friends. R=reed@google.com BUG=skia:2285 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737363002 Committed: https://skia.googlesource.com/skia/+/952538ed50661ad7dff6ec2b7af3f921e1d91b52

Patch Set 1 #

Patch Set 2 : try again on nan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/core/SkCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/private/SkFloatBits.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737363002/1
4 years, 10 months ago (2016-02-25 21:37:02 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/662)
4 years, 10 months ago (2016-02-25 21:38:24 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737363002/20001
4 years, 10 months ago (2016-02-25 21:44:51 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 21:58:03 UTC) #9
caryclark
4 years, 10 months ago (2016-02-25 22:05:23 UTC) #10
reed1
lgtm
4 years, 10 months ago (2016-02-25 22:08:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737363002/20001
4 years, 10 months ago (2016-02-26 12:12:25 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 13:01:45 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/952538ed50661ad7dff6ec2b7af3f921e1d91b52

Powered by Google App Engine
This is Rietveld 408576698