include/private/SkFloatBits.h - Issue 1737363002: fix undefined signed shifts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/private/SkFloatBits.h

Issue 1737363002: fix undefined signed shifts (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: try again on nan Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/private/SkFloatBits.h

diff --git a/include/private/SkFloatBits.h b/include/private/SkFloatBits.h

index 3ddb9ef564cfaaf2dd07e9f04bd1ce02b4b39d35..caad342a4a6b82416c782206d6b6beaa79fe3b22 100644

--- a/include/private/SkFloatBits.h

+++ b/include/private/SkFloatBits.h

@@ -32,7 +32,7 @@ static inline int32_t Sk2sComplimentToSignBit(int32_t x) {

// make x positive

x = (x ^ sign) - sign;

// set the sign bit as needed

- x |= sign << 31;

+ x |= SkLeftShift(sign, 31);

return x;

}

« no previous file with comments | « include/core/SkTypes.h ('k') | src/gpu/effects/GrMatrixConvolutionEffect.cpp » ('j') | no next file with comments »