include/core/SkTypes.h - Issue 1737363002: fix undefined signed shifts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTypes.h

Issue 1737363002: fix undefined signed shifts (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: try again on nan Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTypes.h

diff --git a/include/core/SkTypes.h b/include/core/SkTypes.h

index 756eae862839990a22775303f54cdb2a2308d243..5831ba3e80fa1093e681f20341ba3a7ef43e3d82 100644

--- a/include/core/SkTypes.h

+++ b/include/core/SkTypes.h

@@ -290,7 +290,7 @@ typedef uint8_t SkBool8;

#define SK_MinS32 -SK_MaxS32

#define SK_MaxU32 0xFFFFFFFF

#define SK_MinU32 0

-#define SK_NaN32 (1 << 31)

+#define SK_NaN32 ((int) (1U << 31))

/** Returns true if the value can be represented with signed 16bits

« no previous file with comments | « include/core/SkCanvas.h ('k') | include/private/SkFloatBits.h » ('j') | no next file with comments »