Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1737323002: Wire up /batches in skiaserve (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@skiaserve-1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -18 lines) Patch
M tools/skiaserve/Request.h View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 1 chunk +38 lines, -0 lines 0 comments Download
M tools/skiaserve/Response.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/skiaserve/Response.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A tools/skiaserve/urlhandlers/BatchesHandler.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
M tools/skiaserve/urlhandlers/CmdHandler.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/skiaserve/urlhandlers/UrlHandler.h View 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
joshualitt
This depends on my earlier change to GrAuditTrail, I figured I'd put up a CL ...
4 years, 9 months ago (2016-02-25 20:46:28 UTC) #3
jcgregorio
lgtm
4 years, 9 months ago (2016-02-25 20:58:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737323002/20001
4 years, 9 months ago (2016-02-26 16:14:02 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 16:22:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1e5884b066da57a0c5dd9a0f9489b0bb1c3b3c34

Powered by Google App Engine
This is Rietveld 408576698